Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove contrib folder #4003

Merged
merged 1 commit into from Aug 18, 2023
Merged

Conversation

davidspek
Copy link
Collaborator

Closes: #3992, #3541

The contrib folder isn't maintained and is mainly just bloating this repo. This PR removes it to clean shop.

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +1.97% 🎉

Comparison is base (97957b1) 55.62% compared to head (6fea548) 57.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4003      +/-   ##
==========================================
+ Coverage   55.62%   57.59%   +1.97%     
==========================================
  Files         110      108       -2     
  Lines       11001    10536     -465     
==========================================
- Hits         6119     6068      -51     
+ Misses       4196     3792     -404     
+ Partials      686      676      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milosgajdos milosgajdos merged commit 9139f52 into distribution:main Aug 18, 2023
12 checks passed
@thaJeztah
Copy link
Member

From the last ticket;

completely fair. The travesty is that I feel the community needs a simple token server, and a demo of using it with the distribution-registry. 😿

Is there anything in that area that we need to preserve in contrib? ("contrib" is implicitly considered "may be unmaintained")

@thaJeztah
Copy link
Member

Doh! didn't refresh my tab, and didn't realise it was already merged

@milosgajdos
Copy link
Member

We dont want to preserve anything from there 😄 if the need arises we can reconsider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove contrib folder
5 participants