Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schema1 references from registry client #4007

Merged
merged 2 commits into from Aug 21, 2023

Conversation

milosgajdos
Copy link
Member

We've replaced all the schema1 references with OCI schema manifest in the next step towards #3966

Note, there are some TODO items that must be addressed at some point in the future once the schema1 package is removed completely from the codebase.

We've replaced all the schema1 references with OCI schema manifest.
Note, there are some TODO items that must be addressed at some point in
the future once the schema1 package is removed completely from the
codebase.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (597e8a6) 57.67% compared to head (11c341a) 57.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4007   +/-   ##
=======================================
  Coverage   57.67%   57.67%           
=======================================
  Files         108      108           
  Lines       10525    10525           
=======================================
  Hits         6070     6070           
  Misses       3781     3781           
  Partials      674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidspek davidspek added this to the Registry/3.0.0 milestone Aug 21, 2023
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Copy link
Collaborator

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milosgajdos milosgajdos merged commit 1a4638a into distribution:main Aug 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants