Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Makefie update #4018

Merged
merged 2 commits into from Aug 28, 2023
Merged

Conversation

milosgajdos
Copy link
Member

@milosgajdos milosgajdos commented Aug 25, 2023

This PR updates Makefile so the default action is help.
We group related targets into semantic groups - this makes the help output easier to read for the end user.

See here:

$ make

Usage:
  make

Build
  bin/%                        build individual binary
  binaries                     build binaries
  build                        build go packages
  image                        build docker image IMAGE_NAME=<name>
  clean                        clean up binaries
  vendor                       update vendor
  mod-outdated                 check outdated dependencies

Test
  test                         run tests, except integration test with test.short
  test-race                    run tests, except integration test with test.short and race
  test-full                    run tests, except integration tests
  integration                  run integration tests
  coverage                     generate coverprofiles from the unit tests

Validate
  lint                         run all linters
  validate                     run all validators
  validate-git                 validate git
  validate-vendor              validate vendor

Go binaries:   bin/registry bin/digest bin/registry-api-descriptor-template
Docker image: distribution/distribution:latest

This commit updates Makefile so the default action is help.
We group related targets into semantic groups - this make the help
output easier to read for the end user.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (293b588) 57.76% compared to head (d0c0b7b) 57.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4018   +/-   ##
=======================================
  Coverage   57.76%   57.76%           
=======================================
  Files         108      108           
  Lines       10500    10500           
=======================================
  Hits         6065     6065           
  Misses       3762     3762           
  Partials      673      673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Jamstah Jamstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

Makefile Outdated Show resolved Hide resolved
Co-authored-by: James Hewitt <james.hewitt@gmail.com>
Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
@milosgajdos milosgajdos merged commit e948e1b into distribution:main Aug 28, 2023
12 checks passed
@milosgajdos milosgajdos deleted the makefile-cleanup branch August 28, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants