Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.20 #4021

Merged
merged 2 commits into from Aug 28, 2023
Merged

Update to go 1.20 #4021

merged 2 commits into from Aug 28, 2023

Conversation

Jamstah
Copy link
Collaborator

@Jamstah Jamstah commented Aug 27, 2023

We probably want to release on a supported version of go

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2023 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (293b588) 57.76% compared to head (1a3e73c) 57.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4021   +/-   ##
=======================================
  Coverage   57.76%   57.76%           
=======================================
  Files         108      108           
  Lines       10500    10500           
=======================================
  Hits         6065     6065           
  Misses       3762     3762           
  Partials      673      673

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jamstah
Update to go 1.20
0eb8fee 
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
@Jamstah Jamstah force-pushed the go-1.20 branch 2 times, most recently from 6463c49 to 5ddaf55 Compare August 27, 2023 10:09
@Jamstah Jamstah marked this pull request as ready for review August 27, 2023 12:27
milosgajdos
milosgajdos approved these changes Aug 27, 2023
View reviewed changes
registry/proxy/proxyblobstore_test.go Show resolved Hide resolved
registry/storage/driver/testsuites/testsuites.go Outdated Show resolved Hide resolved
thaJeztah
thaJeztah reviewed Aug 27, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll probably also have to update golangci-lint to the latest version (it usually needs to be updated to be compatible with newer Go versions)

distribution/dockerfiles/lint.Dockerfile

Line 5 in 293b588

ARG GOLANGCI_LINT_VERSION=v1.52

.github/workflows/build.yml
@@ -26,8 +26,8 @@ jobs:
fail-fast: false
matrix:
go:
- 1.18
- 1.19.10
- 1.20.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go now also provides .0 versions, so we can use 1.21.0 here.

Wondering if we should keep 1.18 in the list as an "old" version to test against (for projects that consume the code as a library).

Although perhaps less important for the main (unreleased / unstable) branch

Copy link
Collaborator Author

@Jamstah Jamstah Aug 27, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's out of support, they shouldn't be using it.

Although yes, it might be more important if we already had a release out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 1.21.0. Will leave 1.18 out for now.

Dockerfile
@@ -1,6 +1,6 @@
# syntax=docker/dockerfile:1

ARG GO_VERSION=1.19.10
ARG GO_VERSION=1.20.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason not to update the Dockerfiles to 1.21.0 (now that it's released)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are taking it slowly. 1.21.x is very fresh from the oven

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ this

@Jamstah Jamstah force-pushed the go-1.20 branch 2 times, most recently from f15b496 to e0f1b3e Compare August 28, 2023 08:29
@Jamstah
Handle rand deprecations in go 1.20
1a3e73c 
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
@Jamstah Jamstah added the area/go-version Go update vresion label Aug 28, 2023
davidspek
davidspek approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm also for waiting a little bit for Go 1.21, possibly a month or 2.

@milosgajdos milosgajdos merged commit db460d2 into distribution:main Aug 28, 2023
12 checks passed
@thaJeztah thaJeztah mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosgajdos milosgajdos milosgajdos approved these changes

@thaJeztah thaJeztah thaJeztah left review comments

@davidspek davidspek davidspek approved these changes

@wy65701436 wy65701436 Awaiting requested review from wy65701436

@deleteriousEffect deleteriousEffect Awaiting requested review from deleteriousEffect

Assignees
No one assigned
Labels
area/go-version Go update vresion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Jamstah @codecov-commenter @milosgajdos @thaJeztah @davidspek