Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate storage driver context to S3 API calls #4036

Merged
merged 1 commit into from Sep 4, 2023

Conversation

milosgajdos
Copy link
Member

Only some of the S3 storage driver calls were propagating context to the S3 API calls. This PR updates the S3 storage driver so the context is propagated to all the S3 API calls by using WithContext SDK calls.

Only some of the S3 storage driver calls were propagating context to the
S3 API calls. This commit updates the S3 storage drivers so the context
is propagated to all the S3 API calls.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Copy link
Collaborator

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milosgajdos milosgajdos merged commit b6d0d38 into distribution:main Sep 4, 2023
12 checks passed
@milosgajdos milosgajdos deleted the s3-context branch September 4, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants