registry/api: move all errors to "errcode" package, and split "Register" to internal / exported #4040
Conversation
| var ( | ||
| // ErrorCodeDigestInvalid is returned when uploading a blob if the | ||
| // provided digest does not match the blob contents. | ||
| ErrorCodeDigestInvalid = errcode.Register(errGroup, errcode.ErrorDescriptor{ |
There was a problem hiding this comment.
Gonna be honest; I still don't know if there was a specific reason to split these errors between the errcode and api/v2 package; I looked at this various times, because to check for these codes, it's needed to import the api/v2 package (including all the routes it defines), which always stood out as "odd", but perhaps there was a specific reason to split the various errors.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use the non-exported function to all errors; there's currently no external consumers of this function (perhaps it should be deprecated). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
move_api_errors
branch
from
e673614
to
0104adf
Compare
|
What is the reason for this change @thaJeztah? |
|
This was an attempt not having to import the whole registry api (just to be able to handle errors it returns); https://github.com/docker/cli/blob/f74f88445f8b23fe4804f1072e5f376cfbe46487/cli/registry/client/fetcher.go#L204-L206 But I may need more to be moved, e.g. distribution/registry/api/v2/urls.go Line 38 in 90939f1 |
|
Oh, right. Yeah, I'd love this project to be more modular(ised), too. IIRC, these used to be used in some docs generator but I may be wrong so feel free to ignore me 🤔 |
|
Yeah, some parts are really coupled (in this case, the API server implementation (gorilla/mux) leaks all the way into the client, which always felt "off". The errors in general are hard to work with (and I'm not even sure if we handle them correctly everywhere); I know where some of the ideas for these "structured" errors originated from at the time, but they're lacking in utilities to handle them. |
Move all errors to the errcode package