refactor redis cache #4081
Merged
refactor redis cache #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes some `conn` parameters of private functions, which can be obtain from the struct itself. The `conn` is for the old `redisgo` library, which is replaced by `go-redis` in distribution#4019. Signed-off-by: bin liu <liubin0329@gmail.com>
milosgajdos
approved these changes
Sep 28, 2023
milosgajdos
requested review from
Jamstah,
thaJeztah,
davidspek and
deleteriousEffect
Jamstah
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some
connparameters of private functions, which can be obtain from the struct itself. Theconnis for the oldredisgolibrary, which is replaced bygo-redisin #4019.