New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker Hub README and keep it in sync with this repository. #4087
Update Docker Hub README and keep it in sync with this repository. #4087
Conversation
CC: @crazy-max for the CI / GHA review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually I think you just want to update the README on release or on every push on main?
Ideally everytime we modify the dockerhub readme, so on every merge to main seems like the best thing to do - IF we could do that conditionally thatd be the biggest win |
Ok then I would suggest a dedicated workflow named name: dockerhub-readme
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
on:
push:
branches:
- 'main'
paths:
- '.github/dockerhub-readme.yml'
- 'docs/dockerhub.md'
env:
DOCKERHUB_SLUG: distribution/distribution
jobs:
update:
runs-on: ubuntu-latest
steps:
-
name: Update Docker Hub Description
uses: peter-evans/dockerhub-description@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
repository: ${{ env.DOCKERHUB_SLUG }}
readme-filepath: ./docs/dockerhub.md |
Ah, yeah, that's much better than my cruft 😅 Let me update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Would it make sense to have this page live in either https://github.com/docker/distribution-library-image |
I have thought about it of course but
Keeping those in sync with Hub from this repo is a fool's errand IMHO, hence this approach |
Right, but both those repositories are the ones that are used to publish the image to docker hub, so thought it would probably be the most appropriate location (as this repository itself doesn't publish an image) |
Wrong. It does, but not an Official image. See the PR. We maintain https://hub.docker.com/r/distribution/distribution and actively push to it. |
DOH! My bad I thought this was about the official image 🙈 |
Can you LGTM this then @thaJeztah 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM; can you squash the touch-up commits where needed?
This commit * adds a new docs page (`dockerhub.md`) that contains Docker Hub README * updates the default config that gets backed into the docker image * updates CI with a new workflow job that keeps Docker Hub README in sync with the contents of the `docs/dockerhub.md` file Co-authored-by: CrazyMax <github@crazymax.dev> Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
ed81ccb
to
f2a72d7
Compare
Squashed. Should be goo to go @thaJeztah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR
docs/dockerhub.md
) that contains the new contents of theREADME
fordistribution/distribution
Docker Hub repositorydocs/dockerhub.md
fileCloses #4014