Make our UUID package internal #4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays there are much, much better UUID implementations to choose from, such as github.com/google/uuid. Prevent external users from importing our bespoke implementation so that we can change or migrate away from it internally without introducing breaking changes. Signed-off-by: Cory Snider <csnider@mirantis.com>
milosgajdos
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
So I wonder if we could just replace this package with github.com/google/uuid and chuck this. I'm ok with making this internal as the first step. CC: @Jamstah
|
Replacing it seems sensible to be. Also happy with making it internal and replacing it later. |
Jamstah
approved these changes
Oct 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays there are much, much better UUID implementations to choose from, such as github.com/google/uuid. Prevent external users from importing our bespoke implementation so that we can change or migrate away from it internally without introducing breaking changes.