cleanup: a small Azure driver cleanup #4138
Conversation
Just so we can make the code a bit more consistent with the rest of the storage drivers. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
| @@ -483,6 +499,8 @@ func is404(err error) bool { | |||
| ) | |||
| } | |||
|
|
|||
| var _ storagedriver.FileWriter = &writer{} | |||
There was a problem hiding this comment.
I am not sure we need this here as newWriter returns storagedriver.FileWriter. We do add this check in the gcs driver so we should maybe remove it from there.
Though we should probably prefer returning struct types and not interfaces 🤔
There was a problem hiding this comment.
Technically we don't need it, though it doesn't hurt to be explicit about intent.
Though we should probably prefer returning struct types and not interfaces 🤔
In general, yes. In this instance, we have to return the interface-typed value for the driver to satisfy the storagedriver.StorageDriver interface.
| @@ -452,10 +468,9 @@ func (d *driver) listBlobs(ctx context.Context, virtPath string) ([]string, erro | |||
| } | |||
| for _, blob := range resp.Segment.BlobItems { | |||
| if blob.Name == nil { | |||
| return nil, fmt.Errorf("required blob property Name is missing while listing blobs under: %s", listPrefix) | |||
| return nil, fmt.Errorf("missing blob Name when listing prefix: %s", listPrefix) | |||
There was a problem hiding this comment.
I believe the original message is clearer in this context.
| @@ -34,11 +37,15 @@ type driver struct { | |||
| copyStatusPollDelay time.Duration | |||
| } | |||
|
|
|||
| type baseEmbed struct{ base.Base } | |||
| type baseEmbed struct { | |||
There was a problem hiding this comment.
love this fmt, but it could be done by golint?
Just so we can make the code a bit more consistent with the rest of the storage drivers.
Most of the updates in this PR are stylistic so the code across the drivers is more consistent in style.
Additions:
driverandwriter100) and someifcondition checksPTAL @corhere