Plumb contexts into health checks #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corhere
requested review from
Jamstah,
milosgajdos,
thaJeztah,
squizzi and
deleteriousEffect
4 tasks
milosgajdos
approved these changes
Oct 28, 2023
| } | ||
| updater := health.NewThresholdStatusUpdater(app.Config.Health.StorageDriver.Threshold) | ||
| healthRegistry.Register("storagedriver_"+app.Config.Storage.Type(), updater) | ||
| go health.Poll(app, updater, storageDriverCheck, interval) |
There was a problem hiding this comment.
Love that we've ripped out the goroutine launch from the original updated implementation where it was hiding to this place <3
There was a problem hiding this comment.
I noticed that the original logic is simple and clear, and it doesn't require invoking the go function each time to register a periodic checker.
There was a problem hiding this comment.
I noticed that the original logic is simple and clear, and it doesn't require invoking the go function each time to register a periodic checker.
This isn't registering the check - this is starting a goroutine that is doing the polling
|
This needs a rebase @corhere |
squizzi
approved these changes
Nov 16, 2023
|
Ping @corhere wanna rebase and squash this? We've got approvals to merge this in |
Signed-off-by: Cory Snider <csnider@mirantis.com>
Allow health checkers to abort if the request context is canceled. Modify the checkers to respect context cancelation and return wrapped errors so the caller of CheckStatus() would be able to discriminate true failed checks from checks which were aborted because the context became done. Signed-off-by: Cory Snider <csnider@mirantis.com>
The API for periodic health checks is repetitive, with a distinct function for polling a checker to each kind of updater. It also gives the user no control over the lifetime of the polling goroutines nor which context is passed into the checker. Replace the existing PeriodicXYZChecker functions with a single Poll function which composes an Updater with a Checker. Its context parameter is passed into the checker and also controls when the polling loop terminates. To guard against health checks failing closed (ostensibly healthy) when the polling loop is terminated, the updater is forcefully updated to an error status, overriding any configured threshold. Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
contextify-health-checks
branch
from
0ce4eab
to
f2cbfe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.