Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: S3 driver docs #4194

Merged
merged 1 commit into from Dec 18, 2023

Conversation

milosgajdos
Copy link
Member

We were missing documentation for some of the configuration options.

We were missing documentation for some of the configuration options.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Copy link
Collaborator

@Jamstah Jamstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving an approve, but one question about the useragent, does it actually work?

docs/content/storage-drivers/s3.md Show resolved Hide resolved
@milosgajdos
Copy link
Member Author

PTAL @thaJeztah

Copy link
Collaborator

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milosgajdos milosgajdos merged commit 01e6f33 into distribution:main Dec 18, 2023
15 checks passed
@milosgajdos milosgajdos deleted the s3-driver-docs-update branch December 18, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants