Opt: refector tag list pagination support (stage 1) #4360
+150
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: njucjc <njucjc@gmail.com>
github-actions
bot
added
area/storage
area/proxy
njucjc
commented
May 21, 2024
| @@ -563,9 +563,11 @@ func TestTagsAPI(t *testing.T) { | |||
| queryParams: url.Values{"last": []string{"does-not-exist"}, "n": []string{"3"}}, | |||
| expectedStatusCode: http.StatusOK, | |||
| expectedBody: tagsAPIResponse{Name: imageName.Name(), Tags: []string{ | |||
| "jyi7b", | |||
There was a problem hiding this comment.
Because jyi7b > does-not-exist > asj9e, so I think the expectedBody should be changed to [jyi7b, kb0j5, sb71y ].
|
@milosgajdos PTAL |
|
As agreed in the other PR we'll have a look at this once the new spec is released. Appreciate the work though! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 1 for this PR：
storagedriver.WithStartAfterHintto optimize the current tags list API implementation. When specifying paging parameters, there is no need to load all tags in the repository into memory.