UUID package improvements #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes distribution#782 Signed-off-by: Darren Shepherd <darren@rancher.com>
Signed-off-by: Stephen J Day <stephen.day@docker.com>
| @@ -30,7 +29,7 @@ var ( | |||
|
|
|||
| // Loggerf can be used to override the default logging destination. Such | |||
| // log messages in this library should be logged at warning or higher. | |||
| Loggerf = log.Printf | |||
| Loggerf func(format string, args ...interface{}) = func(format string, args ...interface{}) {} | |||
There was a problem hiding this comment.
no need for type, it will infer from value
|
Do we need a check on whether Loggerf is nil in Generate, before it is used? |
|
@aaronlehmann No, because it is initialized. |
Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
uuid-package-improvements
branch
from
7159de6
to
2c9ab4f
Compare
|
LGTM |
|
Ah, missed the fact that Loggerf is initialized. LGTM. |
|
@tiborvass Are you going to update in docker/docker? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid errant log messages, we've disabled logging by default when uuid is having trouble accessing
/dev/urandom. This also takes the work from #786 and incorporates the feedback.This carries #784 and #786.
cc @jfrazelle @tiborvass @ibuildthecloud