add notes and godoc about registering algorithms #13
+89
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thaJeztah
commented
May 9, 2024
thaJeztah
commented
- relates to Add note about parsing images with digest #12
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| // ) | ||
| // | ||
| // Even though digests may be assemblable as a string, always verify your input | ||
| // with [digest.Parse] or use [digest.Digest.Validate] when accepting untrusted |
There was a problem hiding this comment.
I believe referencing another package's godoc is done by using the package full name so in this case it would be something like [github.com/opencontainers/go-digest.Parse]?
At least that's what I understood from this reference
There was a problem hiding this comment.
Oh, that's a good one. I should check.
In case it's useful; you can run the pkg.go.dev docs locally if you install the pkgsite binary; https://github.com/golang/pkgsite
(It's nice to look how the docs look when making such changes!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.