rename output_size to output_size_limit as per review comment

distribworks · Jan 27, 2022 · 62a96b5 · 62a96b5
1 parent 98e37fc
commit 62a96b5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/dkron/api.go b/dkron/api.go
@@ -337,9 +337,9 @@ func (h *HTTPTransport) executionsHandler(c *gin.Context) {
 		sort = "started_at"
 	}
 	order := c.DefaultQuery("_order", "DESC")
-	output_size, err := strconv.Atoi(c.DefaultQuery("output_size", ""))
+	output_size_limit, err := strconv.Atoi(c.DefaultQuery("output_size_limit", ""))
 	if err != nil {
-		output_size = -1
+		output_size_limit = -1
 	}
 
 	job, err := h.agent.Store.GetJob(jobName, nil)
@@ -362,12 +362,12 @@ func (h *HTTPTransport) executionsHandler(c *gin.Context) {
 		return
 	}
 
-	if output_size > 0 {
+	if output_size_limit > 0 {
 		// truncate execution output
 		for _, execution := range executions {
 			_s := len(execution.Output)
-			if _s > output_size {
-				execution.Output = execution.Output[_s-output_size:]
+			if _s > output_size_limit {
+				execution.Output = execution.Output[_s-output_size_limit:]
 			}
 		}
 	}

diff --git a/ui/src/dataProvider.ts b/ui/src/dataProvider.ts
@@ -18,7 +18,7 @@ const myDataProvider = {
             _order: order,
             _start: (page - 1) * perPage,
             _end: page * perPage,
-            output_size: 200,
+            output_size_limit: 200,
         };
         const url = `${apiUrl}/${params.target}/${params.id}/${resource}?${stringify(query)}`;