Allow multiple brokers in kafka executor #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Espina2
force-pushed
the
kafka-executor-multiple-brokers
branch
6 times, most recently
from
2690b08
to
acfcfb3
Compare
|
@vcastellm can you take look? |
yvanoers
reviewed
Jan 15, 2022
Espina2
force-pushed
the
kafka-executor-multiple-brokers
branch
from
acfcfb3
to
cd9417a
Compare
This are failing tough |
I'm checking the CI |
|
Let me know if there is anything I can help |
|
SSL tests certs updated, rebase with master and it should work @Espina2 |
Signed-off-by: Paulo Moura <itsme@paulomoura.com.pt>
Espina2
force-pushed
the
kafka-executor-multiple-brokers
branch
from
cd9417a
to
bfb8004
Compare
|
@vcastellm done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka is supposed to be distributed, passing only broker can make messages fail if for some reason the broker is not up. In order to circumvent that issue, we can use multiple brokers. This can also improve the publishing rate.
Signed-off-by: Paulo Moura itsme@paulomoura.com.pt