Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Die on plugin communication error #658

Merged
merged 1 commit into from Dec 11, 2019
Merged

Conversation

vcastellm
Copy link
Member

All plugins uses safe code for error handling so in this case we can not do anything but die, exactly the same as in processor plugins.

Related to #652

All plugins uses safe code for error handling so in this case we can not do anything but die, exactly the same as in processor plugins.
@davidgengenbach
Copy link

davidgengenbach commented Dec 10, 2019

@Victorcoder This will result in the main process getting killed when there was an error executing on the client (= the plugin) - as far as I understand?
This also means that a lot of time can pass before the plugin-death will be detected (= for jobs which are executed every week or so).
It may be interesting to add periodic health-checks to check for the plugin-health - and proceed to die when the plugins are not healthy.

Just an idea!

@vcastellm
Copy link
Member Author

@davidgengenbach plugins processes should be considered as being the same thing as the main process, if one dies the main process should die fast as you said.

I will go with this PR better than nothing and I will left #655 open as an improvement.

@vcastellm vcastellm merged commit 27e82b6 into master Dec 11, 2019
@vcastellm vcastellm deleted the plugin_status_check branch December 11, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants