Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert shell plugin to internal plugin #975

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Convert shell plugin to internal plugin #975

merged 2 commits into from
Jul 22, 2022

Conversation

vcastellm
Copy link
Member

The purpose of this PR is to embed the shell plugin in the main dkron binary, that will facilitate creating a single binary with the most important executor, for easy deployment using a single binary.

The purpose of this PR is to embed the shell plugin in the main dkron binary, that will facilitate creating a single binary with the most important executor, for easy deployment using a single binary.
@vcastellm vcastellm requested a review from yvanoers June 6, 2021 17:10
@vcastellm vcastellm added the 4.x label Jun 6, 2021
cmd/plugins.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@yvanoers yvanoers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vcastellm vcastellm changed the base branch from master to 4.x July 22, 2022 18:15
@vcastellm vcastellm merged commit 345ca8c into 4.x Jul 22, 2022
@vcastellm vcastellm deleted the internal_plugin branch July 22, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants