New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity checks for auction #34

Closed

madvas opened this issue Oct 13, 2017 · 0 comments

Assignees

Contributor

madvas commented Oct 13, 2017 •

edited

Loading

Implement sanity checks for auction properties as suggested in audit https://gist.github.com/Arachnid/3416e5a85b5b67eb9cdfa2252a5e28d9#lack-of-sanity-checks-on-auction-end-time

Auction end time can't be longer than 4 months.
Time Extension can't be longer than duration from now to auction end time

also add some simple tests please

madvas assigned wambat

madvas closed this as completed in

6b27478

madvas added a commit that referenced this issue


          Merge pull request #40 from wambat/iss34

55dd2b9

Sanity checks, fixes #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment