Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove Ant properties #3011

Merged
merged 4 commits into from Jul 13, 2018

Conversation

jelovirt
Copy link
Member

@jelovirt jelovirt commented Jul 4, 2018

Description

Remove dost.jar.path property and deprecate dost.class.path properties.

Motivation and Context

The currently correct way to define the classpath is outside the Ant process, thus dost.class.path is obsolete. The dost.jar.path is a previously deprecated alias for dost.class.path and can be removed after being deprecated since 2.1.

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
The property was deprecated in DITA-OT 2.1.

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt added ant Plug-in configuration with Ant priority/medium Medium (or unknown) priority issue enhancement Changes to an existing feature labels Jul 4, 2018
@jelovirt jelovirt added this to In progress in 3.2 via automation Jul 4, 2018
@jelovirt jelovirt requested a review from robander July 4, 2018 21:15
@jelovirt
Copy link
Member Author

jelovirt commented Jul 5, 2018

I'm having trouble with the classpath configuration in end to end tests. The modifications work when running DITA-OT in a normal environment, but in end to end tests Ant is unable to find Fop class.

Exclude transitive dependency to Xalan.

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Copy link
Member Author

jelovirt commented Jul 5, 2018

Had to tweak test classpath and remove Xalan as a transitive dependency.

@jelovirt jelovirt moved this from In progress to Review in 3.2 Jul 6, 2018
@jelovirt jelovirt merged commit 19f5e4d into dita-ot:develop Jul 13, 2018
3.2 automation moved this from Review to Done Jul 13, 2018
@jelovirt jelovirt added this to the 3.2 milestone Jul 13, 2018
jason-fox added a commit to jason-fox/com.here.validate.svrl that referenced this pull request May 13, 2019
jason-fox added a commit to jason-fox/com.here.validate.svrl.text-rules that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ant Plug-in configuration with Ant enhancement Changes to an existing feature priority/medium Medium (or unknown) priority issue
Projects
No open projects
3.2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants