Use last-token-of-class att rather than local name to check target el… #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement Added unit test for conref to specialization Signed-off-by: Eliot Kimber <ekimber@contrext.com>
drmacro
force-pushed
the
feature/fix-conref-to-specialization
branch
from
13e5708
to
181d60e
Compare
robander
reviewed
Mar 25, 2019
| @Test | ||
| public void testconref_to_specialization() throws Throwable { | ||
| builder().name("conref_to_specialization") | ||
| .transtype(XHTML) |
There was a problem hiding this comment.
We could save a bit of time on the integration test process if we only run PREPROCESS (since this is testing something that's only part of preprocessing) -- or possibly just add this conref test into an existing integration test for conref. I'm not sure if any of the existing tests are a good fit though.
There was a problem hiding this comment.
I just used an existing conref test as a model. They seemed to be very narrow in their focus.
Limiting it to preprocess makes sense though.
jelovirt
added
bug
preprocess/conref
priority/medium
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ement
Signed-off-by: Eliot Kimber ekimber@contrext.com
name: Pull request
about: Correct conref processing to resolve conrefs to specializations of the referencing element
Description
Updates conrefImpl.xsl to use last token of @Class attribute of referencing element in place of local name to select target element.
Motivation and Context
Make behavior correct per DITA spec.
How Has This Been Tested?
Tested with dita-test-case tests for this-topic references:
https://github.com/dita-community/dita-test-cases/tree/master/this-topic-fragment-ids
Type of Changes
Checklist
My code follows the code style of this project.
I have updated the unit tests to reflect the changes in my code.
I will try to add a unit test.