Use BufferedWriter to output Job for 200 fold performance improvement #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robander
previously approved these changes
Sep 10, 2020
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/job-write-buffered-writer
branch
from
91ff96d
to
adcd908
Compare
robander
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a
BufferedWriterinstead of directFileOutputStreamto serializeJobobjects. On ~23 MB.job.xmlfile, the serialization time is 200 times shorter. The poor performance seems to be caused by slow UTF-8 encoding used byXMLOutputimplementation.Type of Changes
Documentation and Compatibility
No documentation changes needed.