Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Dublin Core metadata field generation to own plug-in #3595

Merged
merged 4 commits into from Sep 30, 2020
Merged

Extract Dublin Core metadata field generation to own plug-in #3595

merged 4 commits into from Sep 30, 2020

Conversation

jelovirt
Copy link
Member

@jelovirt jelovirt commented Sep 27, 2020 •
edited

Description

Extract Dublin Core metadata field generation to own plug-in in HTML5.

Motivation and Context

Make it easier to remove Dublin Core output and modularize Dublin Core specific code.

How Has This Been Tested?

Existing tests pass.

Type of Changes

  • New feature (non-breaking change which adds functionality)

Documentation and Compatibility

Change is backwards compatible.

@jelovirt jelovirt added priority/medium Medium (or unknown) priority issue enhancement Changes to an existing feature plugin/html5 Issue related to HTML5 plug-in labels Sep 27, 2020
@jelovirt jelovirt self-assigned this Sep 27, 2020
@jelovirt jelovirt added this to In progress in Next via automation Sep 27, 2020
@jelovirt jelovirt force-pushed the feature/extract-dublin-core branch 2 times, most recently from 381c025 to 42f14c4 Compare September 27, 2020 13:29
@robander
Copy link
Member

For everything that moves to the DC file, is there a no-op template they're overriding in get-meta.xsl? Just thinking it would be nice to be able to delete that line from your own HTML5 shell and have that drop the DC items, but it would be a pain if you had to add a no-op match="*" mode="gen-metadata" to prevent random text from showing up.

@jelovirt jelovirt changed the title Extract Dublin Core metadata field generation to own stylesheet Extract Dublin Core metadata field generation to own plug-in Sep 27, 2020
@jelovirt
Copy link
Member Author

@robander this already works like that, by default you get no extra metadata and only if you install the DC plugin you get that DC metadata.

@jelovirt
Extract Dublin Core into own stylesheet
5b9e984 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Clean metadata stylesheets
bd997e8 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Move Dublin Core to separate plug-in
519fe40 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Fix tests for Dublin Core
6affc4c 
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt moved this from In progress to Review in progress in Next Sep 30, 2020
Next automation moved this from Review in progress to Reviewer approved Sep 30, 2020
@jelovirt jelovirt merged commit 1d72d00 into develop Sep 30, 2020
Next automation moved this from Reviewer approved to Done Sep 30, 2020
@jelovirt jelovirt deleted the feature/extract-dublin-core branch September 30, 2020 16:34
@jelovirt jelovirt added this to the Next milestone Sep 30, 2020
@infotexture infotexture mentioned this pull request Oct 8, 2020
Merged
@infotexture infotexture mentioned this pull request Nov 22, 2020
Closed
4 tasks
@raducoravu raducoravu mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robander robander robander approved these changes

Assignees

@jelovirt jelovirt

Labels
enhancement Changes to an existing feature plugin/html5 Issue related to HTML5 plug-in priority/medium Medium (or unknown) priority issue
Projects
No open projects
Next
  
Done
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jelovirt @robander