Update to Gradle 7.2 #3803
Merged
Update to Gradle 7.2 #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
added
priority/medium
jelovirt
force-pushed
the
feature/gradle-7-2
branch
2 times, most recently
from
69e9ddb
to
a5ee4ef
Compare
infotexture
reviewed
Sep 19, 2021
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip | |||
There was a problem hiding this comment.
This is the minimal upgrade path per Gradle docs:
Note that running the wrapper task once will update
gradle-wrapper.propertiesonly, but leave the wrapper itself ingradle-wrapper.jaruntouched. This is usually fine as new versions of Gradle can be run even with ancient wrapper files. If you nevertheless want all the wrapper files to be completely up-to-date, you’ll need to run thewrappertask a second time.
In dita-ot/docs#355, I also upgraded the wrapper.
Shall we do that here too?
There was a problem hiding this comment.
Yeah, I'll update the wrapper just in case
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/gradle-7-2
branch
from
a5ee4ef
to
98b9ac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to build scripts to work with Gradle 7.2.
Motivation and Context
Keep up with Gradle development and make it easier for docs repo to also use new Gradle version.
How Has This Been Tested?
Build and distribution build works.
Type of Changes
Documentation and Compatibility
None