Remove PDF2 AXF and RenderX in favour of separate repo #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
added
plugin/pdf
jelovirt
changed the title
jelovirt
force-pushed
the
feature/remove-pdf2-axf
branch
from
ae56642
to
ed410b1
Compare
infotexture
previously approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Tested with a fresh Git worktree , both external plug-ins are installed correctly and distribution build succeeds. ✅
|
Should we also remove the corresponding lines from the Git ignore file? |
|
There are still traces of XEP in org.dita.pdf2/resource/messages.xml. Would it make sense to move these to the external plug-in as well, or are there reasons to keep them in the core PDF plug-in? |
jelovirt
force-pushed
the
feature/remove-pdf2-axf
branch
from
ed410b1
to
4ce317f
Compare
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/remove-pdf2-axf
branch
from
4ce317f
to
505e1b1
Compare
robander
approved these changes
Oct 2, 2021
infotexture
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
With the migration of the XEP messages from org.dita.pdf2 to dita-ot/org.dita.pdf2.xep@42b8628 for plug-in v3.6.2, I think this is good to go. ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove PDF2 AXF and RenderX plug-ins and install them from dita-ot/org.dita.pdf2.axf and dita-ot/org.dita.pdf2.xep into distribution package.
Motivation and Context
PDF2 AXF and RenderX plug-ins have been moved to their own repos.
How Has This Been Tested?
Distribution build works.
Type of Changes
Documentation and Compatibility
Document that PDF2 AXF and RenderX related bugs should be reported to https://github.com/dita-ot/org.dita.pdf2.axf/issues and https://github.com/dita-ot/org.dita.pdf2.xep/issues, respectively.