Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image default scope #4039

Merged
merged 1 commit into from Nov 6, 2022
Merged

Conversation

jelovirt
Copy link
Member

@jelovirt jelovirt commented Nov 6, 2022

Description

Default missing @scope attribute to external on absolute URIs with http etc. schemes.

Motivation and Context

Matches DITA 1.3 spec section 3.12.13.11 The @scope attribute for default @scope processing.

Fixes #4032

How Has This Been Tested?

Added new tests.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)

@jelovirt jelovirt added bug priority/medium Medium (or unknown) priority issue preprocess labels Nov 6, 2022
Per DITA 1.3 spec 3.12.13.11 "The @scope attribute"
Fixes #4032

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt force-pushed the feature/fix-image-default-scope branch from 07ec1cd to fc8cb7e Compare November 6, 2022 11:32
@jelovirt jelovirt merged commit f318bb1 into release/4.0 Nov 6, 2022
@jelovirt jelovirt deleted the feature/fix-image-default-scope branch November 6, 2022 11:36
@jelovirt jelovirt added this to the Next milestone Nov 6, 2022
infotexture added a commit to dita-ot/docs that referenced this pull request Nov 9, 2022
- dita-ot/dita-ot#4032
- dita-ot/dita-ot#4039

Signed-off-by: Roger Sheen <roger@infotexture.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug preprocess priority/medium Medium (or unknown) priority issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant