Move map specific reader code to map module #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
added
preprocess
enhancement
jelovirt
force-pushed
the
feature/refactor-subject-scheme-reader-3
branch
from
cc47dc8
to
0337f5f
Compare
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/refactor-subject-scheme-reader-3
branch
from
0337f5f
to
7b3383d
Compare
Filtering will take place right after reading, but not during like in topics. Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
jelovirt
force-pushed
the
feature/refactor-subject-scheme-reader-3
branch
from
ade71f4
to
42d3747
Compare
jelovirt
removed
the
internal
jelovirt
force-pushed
the
feature/refactor-subject-scheme-reader-3
branch
2 times, most recently
from
d746cf3
to
87fc02d
Compare
jelovirt
force-pushed
the
feature/refactor-subject-scheme-reader-3
branch
from
87fc02d
to
53aa7aa
Compare
@jelovirt While it's fresh in your mind: could you provide details on which features? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor subject scheme code for preprocess2 to support all features of subject scheme that preprocess supports. This changes how preprocess2 does filtering. Before preprocess2 map filtering was lazy, meaning it happened at the end of preprocess2 map step. This changes the map filtering to be early, after initial map parsing and mapref merge. It's not as early as in preprocess2 topic processing, because filtering requires reading subject schemes and those are part of the map.
Motivation and Context
Support all subject scheme features in preprocess2 that are supported by preprocess.
How Has This Been Tested?
Existing and new tests.
Type of Changes
Documentation and Compatibility
https://www.dita-ot.org/dev/reference/map-first-preprocessing could mention that since DITA-OT 4.2 preprocess2 supports more subject scheme features.