Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XSLT3 for stylesheets #4338

Merged
merged 1 commit into from Dec 11, 2023
Merged

Conversation

chrispy-snps
Copy link
Contributor

@chrispy-snps chrispy-snps commented Dec 8, 2023

Description

Changes XSLT style templates from version 1.0 and 2.0 to version 3.0.

There are no changes to the actual code; only the stylesheet headers.

Motivation and Context

This is a pipecleaner change to flush out any external or third-party incompatibilities that might result from switching to XSLT3. Because there are no code changes, the version change is easily reversed to troubleshoot or work around issues.

How Has This Been Tested?

Automated tests pass. Manual testing with old plug-ins.

Type of Changes

  • New feature (non-breaking change which adds functionality)

Documentation and Compatibility

This doesn't require end-users or plug-in developers to change anything. However, the release notes could link to https://www.w3.org/TR/xslt-30/#incompatibilities.

@stefan-jung
Copy link
Contributor

Thanks, @chrispy-snps . This is backwards compatible and there seems to be no reason not to do it. Many of the 3.0 features are resulting in better code quality.

@chrispy-snps
Copy link
Contributor Author

@stefan-jung - agreed! This will be an exciting step forward in code expressiveness.

When the time comes to actually use some features, I can run the refactoring operation in #4123 to make some code updates programmatically.

@jelovirt jelovirt changed the title Draft: Use XSLT3 for stylesheets Use XSLT3 for stylesheets Dec 10, 2023
@jelovirt jelovirt marked this pull request as draft December 10, 2023 09:42
@jelovirt jelovirt added priority/medium Medium (or unknown) priority issue enhancement Changes to an existing feature labels Dec 10, 2023
Signed-off-by: chrispy <chrispy@synopsys.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt marked this pull request as ready for review December 10, 2023 09:55
@robander robander self-requested a review December 11, 2023 15:57
@jelovirt jelovirt merged commit 01baaf2 into dita-ot:develop Dec 11, 2023
3 checks passed
@jelovirt jelovirt added this to the Next milestone Dec 11, 2023
@chrispy-snps chrispy-snps deleted the feature/use-xslt3 branch January 13, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes to an existing feature priority/medium Medium (or unknown) priority issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants