Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deliverable option to CLI help #4386

Merged
merged 3 commits into from Feb 3, 2024

Conversation

jelovirt
Copy link
Member

@jelovirt jelovirt commented Feb 3, 2024

Description

Add --deliverable option to CLI help.

How Has This Been Tested?

Manual testing.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt jelovirt added bug CLI Command-line interface issues labels Feb 3, 2024
infotexture
infotexture previously approved these changes Feb 3, 2024
Copy link
Member

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the quick fix.

@infotexture
Copy link
Member

If I understand correctly, this option only applies if the --project argument is also set, but I'm not sure how to indicate that in a compact way, or if any other such sub-options exist, so this is fine for now.

Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
Signed-off-by: Jarno Elovirta <jarno@elovirta.com>
@jelovirt
Copy link
Member Author

jelovirt commented Feb 3, 2024

There is no compact way to really say that. It needs to be in the docs, I think.

@jelovirt jelovirt merged commit 2d6809a into release/4.2 Feb 3, 2024
4 checks passed
@jelovirt jelovirt added this to the 4.2 milestone Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CLI Command-line interface issues
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants