Merge PDF and XHTML lists of supported languages #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotexture
requested changes
Nov 18, 2016
There was a problem hiding this comment.
To preserve reference integrity, the reltable entry on Line 16 of reltable.ditamap should be updated to point to the new merged topic.
Also, I think we should make the note an actual <note>.
Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture
approved these changes
Nov 27, 2016
|
Back from long Thanksgiving holiday and seeing all the updates - looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the PDF and XHTML language support is equivalent, we should merge the two topics and use a single table. I've created an initial column for notes, where we can describe any exceptions, such as the lack of index sorting support for Chinese.
I've also included notes in there when one of our two string sets has additional variants. For example, strings in the PDF code only have French, but strings in the common code have Canadian French (the strings all match at this point). I'm not sure if this is the best way to highlight the extra templates, or if they even need highlighting.
Last, I added a note just to point out that we don't actually care about the case of the values when encountered in content.