Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark generated topics with @outputclass="generated" #96

Merged
merged 1 commit into from
May 11, 2016
Merged

Mark generated topics with @outputclass="generated" #96

merged 1 commit into from
May 11, 2016

Conversation

georgebina
Copy link
Member

No description provided.

@infotexture infotexture changed the title Mark generated topics with @outputclass="generated". Mark generated topics with @outputclass="generated" May 9, 2016
@infotexture
Copy link
Member

Related to dita-ot/website#8.

@infotexture infotexture added the enhancement Changes to an existing topic or feature label May 9, 2016
@infotexture infotexture added this to the 2.3 milestone May 9, 2016
@infotexture
Copy link
Member

I'm inclined to merge this, as there should be little impact beyond dita-ot/website#8, and the generated class would allow us to apply custom styling to generated topic titles, which might be a helpful visual indicator of topics derived from plug-in content (in addition to the absent Edit link).

@georgebina In the future, please remember to create a topic branch in your fork and issue the pull request from there to ensure the changes in the pull request remain isolated from revisions to the main development stream.

@jelovirt
Copy link
Member

My preference would be to stick the outputclass on topic, instead of title.

@georgebina
Copy link
Member Author

georgebina commented May 10, 2016 •
edited
Loading

The outputclass on the topic is not propagated into the generated HTML. The code that adds the edit button should work no matter where the generated flag appears as it just looks for a class attribute containing the value generated.

@georgebina
Copy link
Member Author

@infotexture Indeed, I reverted my develop to the correct commit for this PR.

@georgebina georgebina mentioned this pull request May 11, 2016
Merged
@jelovirt jelovirt merged commit 86abee8 into dita-ot:develop May 11, 2016
infotexture added a commit to infotexture/docs that referenced this pull request May 12, 2016
@infotexture
Merge branch 'develop' into feature/pdf-customization
e6f4318 
* develop: (32 commits)
  Verify editing with <oXygen/> XML Web Author
  Mark generated topics with @outputclass="generated". (dita-ot#96)
  Implement review feedback from @robander
  Switch changelog link from branch to '2.2.5' tag
  Add PR 2342 to fixes for dita-ot/dita-ot#1876
  Add details on dita-ot/dita-ot#2329 to 2.2.5 RN
  Add details on dita-ot/dita-ot#2321 to 2.2.5 RN
  Add details on dita-ot/dita-ot#2315 to 2.2.5 RN
  Add details on dita-ot/dita-ot#2312 to 2.2.5 RN
  Add details on dita-ot/dita-ot#2311 to 2.2.5 RN
  Add details on dita-ot/dita-ot#2307 to 2.2.5 RN
  Add details on dita-ot/dita-ot#2266 to 2.2.5 RN
  Add details on dita-ot/dita-ot#1764 to 2.2.5 RN
  Add details on dita-ot/dita-ot#1876 to 2.2.5 RN
  Add details on dita-ot/dita-ot#1709 to 2.2.5 RN
  Add details on dita-ot/dita-ot#1549 to 2.2.5 RN
  Add details on dita-ot/dita-ot#1190 to 2.2.5 RN
  Add 2315 to list of issues resolved for 2.2.5
  Add list of resolved issues to 2.2.5 Release Notes
  Add 2.2.5 section stub & hotfix changelog links
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Changes to an existing topic or feature
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgebina @infotexture @jelovirt