Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible CFLint Changes #10

Closed
jjames967 opened this issue Oct 8, 2015 · 3 comments
Closed

Possible CFLint Changes #10

jjames967 opened this issue Oct 8, 2015 · 3 comments
Labels

Comments

@jjames967
Copy link

Great job on setting up the plugin. I didn't know one for Atom existed. I just installed it as a package and was very helpful.

I may be pulling the CFLint-all.jar out in the next release, because we're switching to a gradle build. It should no longer be necessary, as you wouldn't need to install Maven locally. However, how much of a headache would this cause? I'd be more than happy to help you incorporate Gradle into your current project.

@sjmatta
Copy link
Contributor

sjmatta commented Oct 8, 2015

Thanks! 😀

As far as CLint-all.jar goes - I'm building it from source for now and bundling it, but I'd actually prefer to grab your release version at install time (from someplace like Sonatype Nexus or Maven Central?). Whether it's built with Maven or Gradle probably won't affect this plugin at all since it only needs the final JAR artifact.

@sjmatta
Copy link
Contributor

sjmatta commented Oct 8, 2015

The reason I'm building it from source instead of grabbing the one from mvnrepository.org is because for on-the-fly linting, I had to add stdin and stdout capability. See my pull request at: cflint/CFLint#83 (I'd be happy to make any changes you need me to, to the pull request).

@jjames967
Copy link
Author

awesome. Looks like Ryan sent his recommendations on adding that. I'll give some time for the dev branch to get updated and tested before I send out a release, but glad to know it could help you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants