-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFLint bundling #25
Comments
Ease of use is important. But I don't think you want to tackle "remove dependence on Java". CF itself runs on java -- we should be able to reuse the CF java install without needing to install java somewhere else. that would make sense. |
@ryaneberly Since you maintain the CFLint project, these questions would best be directed to you. Do you see the project introducing any breaking changes? If so, would those be reserved for major version changes? I can see the "ease of use" point, but based on the answers to the questions above I wonder if it would be possible to dynamically pull the latest compatible version then. Either way, my suggestion for storing the location as configuration remains. |
I don't see any breaking changes in the near future. the CLI interface and output have stabilized. I think it's far to expect reasonable compatibility on all future 1.x.x releases |
Following up with this:
|
What is the reason for having CFLint bundled? I see that Issue #8 is where it started and removed the ability to define the path as configuration. If I understand correctly, Issue #10 explains why it needed to be forked, but if those changes are part of core CFLint, is it still necessary? It seems to me that it's more of a dependency.
That said, the roadmap indicates you are looking to "remove the dependency on Java" so perhaps you are considering a complete rewrite which would justify the lack of dependency on the original project.
For now, it would be great if the path or at least file name were left to be from a configuration file instead of having to modify
main.js
when upgrading since the included jar is not kept up-to-date.The text was updated successfully, but these errors were encountered: