-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Examination Result #44
Conversation
@Blonteractor thanks, the PR looks great! |
Integeration tests are still failing because the credentials are not set, is that expected? As the secrets are supposed to be set on the repositary itself |
Not fully expected, but its default behavior to to protect GitHub secrets malicious PRs. Workflows need to be edited to enable secret access |
5aff9a8
to
e08097a
Compare
Restructures the result model to remove additional nesting for the true "result" object. Also includes some spell fixes.
e08097a
to
5298dc3
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of addressing some minor nits and squashing everything down to 5 atomic commits. Looks good to go 🚀
@Blonteractor Congrats on your feature contribution to go-amizone. You did a really solid job 💯 |
Thanks man, here's to more 🎉 |
Closes #36, Adds support for fetching the result of examinations, both course wise and overall semester wise result incldung SGPA, CGPA, etc