Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Examination Result #44

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

Blonteractor
Copy link
Collaborator

@Blonteractor Blonteractor commented Jun 5, 2023

Closes #36, Adds support for fetching the result of examinations, both course wise and overall semester wise result incldung SGPA, CGPA, etc

@ditsuke
Copy link
Member

ditsuke commented Jun 5, 2023

@Blonteractor thanks, the PR looks great! golangci-lint is complaining about a non goimports-ed file, could you address it? You should be able to use autofix golangci-lint run --fix to fix it.

@Blonteractor
Copy link
Collaborator Author

Integeration tests are still failing because the credentials are not set, is that expected? As the secrets are supposed to be set on the repositary itself

@ditsuke
Copy link
Member

ditsuke commented Jun 6, 2023

Integeration tests are still failing because the credentials are not set, is that expected? As the secrets are supposed to be set on the repositary itself

Not fully expected, but its default behavior to to protect GitHub secrets malicious PRs. Workflows need to be edited to enable secret access

Restructures the result model to remove additional nesting for the true
"result" object. Also includes some spell fixes.
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

Copy link
Member

@ditsuke ditsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of addressing some minor nits and squashing everything down to 5 atomic commits. Looks good to go 🚀

@ditsuke ditsuke merged commit 1c37670 into go-amizone:main Jun 9, 2023
@ditsuke
Copy link
Member

ditsuke commented Jun 9, 2023

@Blonteractor Congrats on your feature contribution to go-amizone. You did a really solid job 💯

@Blonteractor
Copy link
Collaborator Author

Thanks man, here's to more 🎉

@Blonteractor Blonteractor deleted the feature-exam-result branch June 10, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Exam results (semester, overall)
2 participants