Ensure that multiline strings and escapes work as expected #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 83 83
Lines 15369 15369
=======================================
Hits 12931 12931
Misses 2438 2438
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jmackie
commented
Jan 13, 2023
| @@ -203,7 +203,7 @@ impl Render for Expression { | |||
| } | |||
| Self::String(inner_string) => { | |||
| accum.push('"'); | |||
| accum.push_str(inner_string); | |||
| accum.push_str(&inner_string.replace('\n', "\\n")); | |||
There was a problem hiding this comment.
The alternative here is that we use backquoted JavaScript strings?
jmackie
force-pushed
the
fix-string-literals
branch
from
99433ee
to
1313a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that some fancier features of string literals work as expected.
This is in anticipation of #65 👀