Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Validation #8

Open
dittos opened this issue Sep 7, 2015 · 2 comments
Open

Type Validation #8

dittos opened this issue Sep 7, 2015 · 2 comments
Assignees
@dittos
Milestone
0.1

Comments

@dittos
Copy link
Owner

dittos commented Sep 7, 2015

In graphql-js, the validity of schema is checked in definition time. (Example)

We currently don't check anything, so should add these checks.
@dittos dittos added this to the 0.1 milestone Sep 16, 2015
@dittos dittos self-assigned this Sep 21, 2015
@jhgg
Copy link
Contributor

jhgg commented Sep 21, 2015

+1 on this. I was mixing up GraphQLArgument and GraphQLField when writing #47. The internals blew up in unexpected ways. We need to guard against this for sure.

@jhgg
Copy link
Contributor

jhgg commented Sep 24, 2015

This happened again. faassen/relaypy#1 graphql-python/graphql-relay-py#2

@jhgg jhgg mentioned this issue Sep 24, 2015
Merged
dittos added a commit that referenced this issue Sep 29, 2015
@dittos
[WIP] Type Validation (#8)
a795a0a
@jhgg jhgg mentioned this issue Oct 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dittos dittos

Labels
None yet
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
2 participants
@dittos @jhgg