Only run init() on commands that need it #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes a change to take into account what command is being run before deciding to run init() or not.
Also includes two minor improvements:
structured
format when querying for componentsContext
The Ditto VSCode extension runs commands such as
generate-suggestions
,component-folders
, andreplace
. These commands don't rely on local data (it calls the Ditto API) and thus doesn't require aconfig.yml
to be present. Because of this, it is unnecessary to run init() when these commands are called.Test Plan
Testing successfully completed in via:
ditto
directoryyarn start generate-suggestions
, verify that theditto
directory isn't createdyarn start pull
, verify that theditto
directory is createdtestfiles/test1.jsx
to include text for a component in your workspace. Verifyyarn start generate-suggestions
results in a suggestion for that text