Skip to content

Commit

Permalink
Small improvements to PR
Browse files Browse the repository at this point in the history
  • Loading branch information
divan committed Sep 25, 2015
1 parent b33870f commit 3439887
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 10 deletions.
15 changes: 5 additions & 10 deletions stack.go
Expand Up @@ -33,13 +33,13 @@ func (s *Stack) Push(val VarValue) {
s.Values = s.Values[1:]
}

if s.Max == nil {
s.Max = val
return
}

switch val.(type) {
case int64:
if s.Max == nil {
s.Max = val
return
}

switch s.Max.(type) {
case int64:
if val.(int64) > s.Max.(int64) {
Expand All @@ -51,11 +51,6 @@ func (s *Stack) Push(val VarValue) {
}
}
case float64:
if s.Max == nil {
s.Max = val
return
}

switch s.Max.(type) {
case int64:
if val.(float64) > float64(s.Max.(int64)) {
Expand Down
7 changes: 7 additions & 0 deletions stack_test.go
Expand Up @@ -7,6 +7,13 @@ func TestPushWithFloatAndIntValue(t *testing.T) {
s.Push(VarValue(int64(0.0))) // from service.go:guessValue
s.Push(VarValue(5.0))
s.Push(VarValue(float64(15.0)))
if _, ok := s.Max.(float64); !ok {
t.Fatalf("Expected Max to be float64, but it's not")
}
s.Push(VarValue(int64(25.0)))
if _, ok := s.Max.(int64); !ok {
t.Fatalf("Expected Max to be int64, but it's not")
}
}

func TestStack(t *testing.T) {
Expand Down

0 comments on commit 3439887

Please sign in to comment.