Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled button and added a loader in login/register #351 #368

Merged
merged 4 commits into from
May 16, 2021
Merged

Disabled button and added a loader in login/register #351 #368

merged 4 commits into from
May 16, 2021

Conversation

okumujustine
Copy link
Contributor

@okumujustine okumujustine commented May 14, 2021 •
edited
Loading

closes #351

I worked on these enhancements

  • added disabled button CSS.
  • added button loader when registering user.

ezgif com-gif-maker

@Mr-spShuvo
@codyseibert

@vercel
Copy link

vercel bot commented May 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/divanov11/mumble/3nxpf36M2FFtgR7aoztEBhgBbpt3
✅ Preview: https://mumble-git-fork-okumujustine-register-button-dis-e9de4f.vercel.app

@okumujustine okumujustine changed the title Disable button and add loader when registering #351 Disabled button and add loader when registering user #351 May 14, 2021
@okumujustine okumujustine changed the title Disabled button and add loader when registering user #351 Disabled button and loader when registering user #351 May 14, 2021
@MidouWebDev
Copy link
Collaborator

MidouWebDev commented May 15, 2021 •
edited
Loading

@okumujustine bro, you did a good job !
i think we should also add this feature for the login button

@MidouWebDev MidouWebDev added the enhancement New feature or request label May 15, 2021
@MidouWebDev MidouWebDev added this to In progress in Tasks - Mumble via automation May 15, 2021
@MidouWebDev MidouWebDev added the feature Feature requests label May 15, 2021
@okumujustine
Copy link
Contributor Author

@okumujustine bro, you did a good job !
i think we should also add this feature for the login button

okay, thanks will work on it today.

@MidouWebDev
Copy link
Collaborator

MidouWebDev commented May 15, 2021 •
edited
Loading

@okumujustine
Awesome, thank you !

@okumujustine
Copy link
Contributor Author

@MidouWebDev

login button loader and disabling added.

Everything should be working great.

@MidouWebDev
Copy link
Collaborator

MidouWebDev commented May 15, 2021 •
edited
Loading

@okumujustine thanks again !

We are going to wait for @Mr-spShuvo 's review

@okumujustine
Copy link
Contributor Author

okumujustine commented May 15, 2021 •
edited by MidouWebDev
Loading

@okumujustine thanks again !

We are going to wait for @Mr-spShuvo 's review

cool, let's wait

@MidouWebDev MidouWebDev changed the title Disabled button and loader when registering user #351 Disabled button and added a loader in login/register #351 May 15, 2021
@okumujustine
Copy link
Contributor Author

@Mr-spShuvo , made all the fixes.

@shahriarpshuvo shahriarpshuvo merged commit f2fe4b2 into divanov11:master May 16, 2021
Tasks - Mumble automation moved this from In progress to Done May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahriarpshuvo shahriarpshuvo Awaiting requested review from shahriarpshuvo

Assignees

@okumujustine okumujustine

Labels
enhancement New feature or request feature Feature requests
Projects
Tasks - Mumble
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Loading indicator on register
3 participants
@okumujustine @MidouWebDev @shahriarpshuvo