Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in src-gen when there is upper case in the syntax epackage name #52

Closed
ebousse opened this issue Feb 25, 2016 · 3 comments
Closed

Comments

@ebousse
Copy link
Contributor

ebousse commented Feb 25, 2016

Hello :)

There are compilation errors in the generated code (src-gen) when the syntax EPackage name has some upper case letters in it.

To reproduce:

  • Create an EMF project with an ecore model whose package name is "PackageThatRocks"
  • Create an xDSML project with a Melange model referencing the ecore as syntax
  • Right click, "Generate all"

And there are many compilation errors in the generated "src-gen".

From what I can try to guess: some generator code of Melange uses toLowerCase when writing a package name in a Java file, even though the real package name might have upper case in it

@ebousse
Copy link
Contributor Author

ebousse commented Feb 25, 2016

Oh, and I was using Melange 0.1.0.201602 from a recent GEMOC Studio.

@tdegueul
Copy link

Hey, thanks for the report!

Indeed, we erroneously put every package name in lower case in the generated code. Who's putting uppercase in a Java package name anyway? Oh, EMF does... :)

Anyway, should be fixed in 64892fb. Pro tip: if you plan to use multiple root packages or subpackages, you are in trouble. But we may work on it if needed.

Cheers

@ebousse
Copy link
Contributor Author

ebousse commented Feb 26, 2016

Anyway, should be fixed in 64892fb. Pro tip: if you plan to use multiple root packages or subpackages, you are in trouble. But we may work on it if needed.

I'll keep that in mind, thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants