Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coral): enable experimental import injection #22

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

sebastiandg7
Copy link
Member

@sebastiandg7 sebastiandg7 commented Nov 10, 2022

add experimental import injection to support bundlers like Vite

Current Behavior

For dev servers with bundlers like Vite, the lazy loaded components can not be resolved.

Expected Behavior

Adding the experimental import injection in the stencil build configuration, let's us support bundlers like Vite.

This may have an impact in out bundle size, so it would be important to keep track of it as the component library grows.

Read more here: https://stenciljs.com/docs/config-extras#experimentalimportinjection

Related Issue(s)

Fixes #

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

add experimental import injection to support bundlers like Vite
@stackblitz
Copy link

stackblitz bot commented Nov 10, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nx-cloud
Copy link

nx-cloud bot commented Nov 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e8caecd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@sebastiandg7 sebastiandg7 merged commit ac81e67 into main Nov 11, 2022
@sebastiandg7 sebastiandg7 deleted the feat/coral/enable-experimental-import-injection branch November 11, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants