Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null as newValue in InsertElement? #4

Closed
jonaskello opened this issue Nov 10, 2018 · 2 comments
Closed

Allow null as newValue in InsertElement? #4

jonaskello opened this issue Nov 10, 2018 · 2 comments

Comments

@jonaskello
Copy link
Member

It seems InsertElement does not allow inserting the value null into an array. Shouldn't this be allowed?

So instead of this:

export interface InsertElement {
  // ...
  readonly newValue: GraphQLCache.EntityFieldValue;
}

We would have this:

export interface InsertElement {
  // ...
  readonly newValue: GraphQLCache.EntityFieldValue | null;
}
@jonaskello
Copy link
Member Author

This is related to gql-cache #26. If EntityFieldValue is updated to include null then this fix is not needed.

@jonaskello
Copy link
Member Author

Actually it seems like this was already fixed. EntityFieldValue includes null in gql-cache 0.9.1, see #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant