Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return keys from denormalize #36

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Return keys from denormalize #36

merged 3 commits into from
Jul 12, 2019

Conversation

jonaskello
Copy link
Member

Fixes #30.

This PR will add the keys of the normalized objects used during denormalization to the output of denormalize().

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #36 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   87.61%   87.72%   +0.11%     
==========================================
  Files           7        7              
  Lines         218      220       +2     
  Branches       56       56              
==========================================
+ Hits          191      193       +2     
  Misses         12       12              
  Partials       15       15
Impacted Files Coverage Δ
src/denormalize.ts 95.45% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c789780...b1ddc7f. Read the comment docs.

@jonaskello jonaskello merged commit 69947eb into master Jul 12, 2019
@jonaskello jonaskello deleted the return-keys branch July 12, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Denormalize should return keys for all object it feched from the cache
1 participant