Upgrade to Webpack 4 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a warning when the config was placed in the wrong plugin array - Use Webpack 4 Tapable/Hooks API when possible - Rename everything related to Webpack 3 or lower API to legacy to avoid confusion - Add section in the readme to warn for missplacing the plugin - Add rimraf as devDependency so that yarn build works for Windows too - Upgrade the example to Webpack 4 latest
|
This looks really good! Thanks for putting it together. Awesome that it is backwards compatible too :-) I will release this as a new major version to make it clear 3.0.0 is the first version to support webpack 4. |
|
Cool, glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the plugin to be fully functional for Webpack 4 and should hopefully solve/prevent the issues people are facing in #9
Small list of changes I did:
There also shouldn't be any deprecation warnings anymore when using it with Webpack 4.