This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Override width and height property and logic. Show help text for override fields #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FE LGTM :) |
| null=True, | ||
| help_text=_( | ||
| 'if this field is provided - it would be used across all devices ' | ||
| 'instead of default for devices types.' |
There was a problem hiding this comment.
the srcset with different sizes for different devices is not implemented yet. (I've never finished it, but it is 80% done)
|
except for the help texts, LGTM |
cyberstar
pushed a commit
that referenced
this pull request
Nov 13, 2015
Override width and height property and logic. Show help text for override fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that if aspect ration is selected - height would be calculated based on aspect ratio.
Note2 Django 1.7 migration (0003) also picked other changes to the fields, so that would be in sync with the code.