Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Add option to remove author from the admin #64

Open
yakky opened this issue Feb 2, 2015 · 11 comments
Open

Add option to remove author from the admin #64

yakky opened this issue Feb 2, 2015 · 11 comments

Comments

@yakky
Copy link
Contributor

yakky commented Feb 2, 2015

Some deployment does not need any author field, keeping it can be confusing for the users

@mikek
Copy link
Contributor

mikek commented Feb 9, 2015

Can be possibly added through NewsBlogConfigForm

@mikek
Copy link
Contributor

mikek commented Feb 11, 2015

@yakky, @tom I've completely forgot to consider doing this through NewsBlogConfigForm in #77 Can we use the simple setting approach now and look into the per instance configuration in some next iteration?

@yakky
Copy link
Contributor Author

yakky commented Feb 12, 2015

Sure, it makes perfectly sense

@intellectronica
Copy link
Contributor

Sure, makes sense.

@mikek mikek closed this as completed in #77 Feb 12, 2015
mikek added a commit that referenced this issue Feb 12, 2015
Allow to disable automatic author (Person object) creation. Fixes #64
@yakky
Copy link
Contributor Author

yakky commented Feb 12, 2015

@mikek This issue is meant to completely remove the "author" field in the admin, actually
Similar to #65

@mikek
Copy link
Contributor

mikek commented Feb 12, 2015

Sorry, I just have noticed this is another issue. Reopening.

@mikek mikek reopened this Feb 12, 2015
@mkoistinen
Copy link
Contributor

What's the consensus on this? Can I suggest we make this setting a boolean on the NewsBlogConfig rather than creating new settings entries. This would also allow a Blog instance of this app to use an author field, whilst allowing a News instance to ignore it in the same project.

@stefanfoulis
Copy link
Contributor

+1 on making this a setting of NewsBlogConfig. This kind of thing is one of the main reasons it exists. News entries might not need authors. Blog entries usually do. In any case, author should not be a mandatory field.
And it should be auto-populated with the following priorities:

  1. the current user already has a Person associated: use it
  2. the current user has a first_name and last_name: auto create a Person and associate it.
  3. set author to None.

Templates should handle missing authors gracefully.

If NewsBlogConfig says there should be no authors:

  • hide the author field in admin

@intellectronica @FinalAngel @yakky what do you think?

@intellectronica
Copy link
Contributor

Yes to all except for auto-creating a Person. IMO that's overreaching.

@yakky
Copy link
Contributor Author

yakky commented Mar 18, 2015

@stefanfoulis +1

1 similar comment
@FinalAngel
Copy link
Member

@stefanfoulis +1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants