This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Rename plugins, use 'articles' rather than 'entries' throughout. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 2fcbf02 on mkoistinen:issue/rename_plugins_etc into * on aldryn:master*. |
|
|
||
| class Migration(SchemaMigration): | ||
|
|
||
| def forwards(self, orm): |
There was a problem hiding this comment.
I read in the south docs once, that data and schema migrations should not be done in the same file. I'm not sure why though and if it is really relevant at all.
|
LGTM 👍 |
mkoistinen
added a commit
that referenced
this pull request
Mar 21, 2015
Rename plugins, use 'articles' rather than 'entries' throughout.
This was referenced Mar 21, 2015
| @@ -1,6 +1,6 @@ | |||
| {% load i18n %} | |||
|
|
|||
| <div class="aldryn aldryn-newsblog aldryn-newsblog-entries aldryn-newsblog-entries-featured"> | |||
| <div class="aldryn aldryn-newsblog aldryn-newsblog-articles aldryn-newsblog-articles-featured"> | |||
There was a problem hiding this comment.
we need to be careful with renaming there as these classes are already used on two sites...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #90, #122, #123 and #126.
All plugins and their models now use app-prefixed names, so, NewsBlogArchivePlugin rather than just ArchivePlugin. Also the the word 'article' now replaces 'entry' throughout. All plugins now use "+" for the related_name to avoid conflicts with other apps in projects. Finally, the empty form declaration has been removed.
There's a lot going on here (all related though), so please do review (and preferably test on a real project after backing up your DB!)
attn: @czpython @mikek @FinalAngel