-
Notifications
You must be signed in to change notification settings - Fork 118
Conversation
Ping @mikek @intellectronica for comments |
1 similar comment
Looks good. I wonder if we should also add the categories, tags and authors to the free text. Might be nice to be able to search for them. |
Do we need to handle this in newsblog, or rather in aldryn-categories? |
Not sure how you could do that in the categories app (with the result that you find blog posts, not categories). |
@czpython can you, please, have a look this: what can be considered a generic enough to add to blog search index? |
if obj.content: | ||
plugins = obj.content.cmsplugin_set.filter(language=language) | ||
for base_plugin in plugins: | ||
instance, plugin_type = base_plugin.get_plugin_instance() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use get_plugin_index_data since it has certain rules to know what to index, to keep consistent accross all apps, this function cleans the plugin data and returns a list that you can then use to extend the text_bits
list.
categories, tags, authors should be added here, not in the categories app. |
Thanks @czpython, will comply |
1 similar comment
b867838
to
26d9559
Compare
@czpython probably we should change a bit aldryn_search to better support parler. See https://github.com/aldryn/aldryn-newsblog/blob/feature/search_index/aldryn_newsblog/search_indexes.py#L24 parler requires the use of |
8a8174d
to
66136b7
Compare
LTGM 👍 |
This allow for indexing using haystack