This repository has been archived by the owner on Oct 29, 2019. It is now read-only.
Fix people list plugin, add group-detail template. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin is using the same template as the view does, so it wasn't respecting plugin settings. also legacy boilerplate didn't had group_detail template which caused an error, basicly it is the same as bootstrap except for using legacy people_item instead of bootstrap person include template.
|
LGTM |
|
Awesome, thank you. |
mkoistinen
added a commit
that referenced
this pull request
Jul 24, 2015
…ate-plugin-settings Fix people list plugin, add group-detail template.
mkoistinen
deleted the
issue/fix-people-list-plugin-template-plugin-settings
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin is using the same template as the view does, so it wasn't respecting plugin settings.
also legacy boilerplate didn't had group_detail template which caused an error, basicly it is the same as bootstrap except for using legacy people_item instead of bootstrap person include template.